Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the project, including the addition of a continuous integration (CI) workflow, dependency updates, improved documentation, and significant refactoring of two key classes (
AlphaOrderandBetaToAlpha), as well as a general cleanup of all the classes in the package (consensusUnion,consensusBES, etc). These changes aim to improve code maintainability, testing capabilities, and overall project structure.CI and Build System Improvements:
.github/workflows/ci.yml) to run Maven tests on pushes and pull requests targeting themainbranch. This includes Java setup, Maven package caching, and test execution.pom.xmlto include JUnit 5 (junit-jupiter) and Apache Commons Math3 dependencies, upgraded the Maven Surefire Plugin to version 3.1.2, and added the JaCoCo plugin for code coverage reporting. [1] [2]Documentation Enhancements:
README.mdto include a CI status badge linking to the new GitHub Actions workflow.Refactoring and Code Improvements:
AlphaOrderclass:computeAlphamethod for calculating ancestral node order.checkExceptions,selectChild,coverEdge) to modularize logic and simplify the main computation flow.BetaToAlphaclass:BackwardEquivalenceSearchDSepclass:consensusBESalgorithm so that it can be easily readable and maintained.DSeparationKeyto avoid repeating calculations.Utilsclass.ConsensusUnionclass:ConsensusBESclass:ConsensusUnionobject that performs the consensus, and then aBackwardEquivalenceSearchDSepthat applies the